fix: FORMS-1703 Added Tags to port numbers, removed unused port number #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revanth-banala
requested review from
WalterMoar,
usingtechnology,
bhuvan-aot,
abhilash-aot,
nimya-aot,
jasonchung1871 and
RyanBirtch-aot
| 5173, // CHEFS Frontend | ||
| 5432, // PostgreSQL | ||
| 8080, // CHEFS Backend | ||
| 8081, |
There was a problem hiding this comment.
If someone is using the container for keycloak, for whatever reason, that would be port 8081.
There was a problem hiding this comment.
Local Keycloak has been removed so that port can go.
usingtechnology
requested changes
Jan 20, 2025
WalterMoar
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Looks great, and this will be really helpful to clarify what the port numbers are used for. Thanks to @usingtechnology for catching the missing frontend config.
revanth-banala
force-pushed
the
fix/1703-adding-tags-to-portnumbers
branch
from
df33ad2 to
087559c
Compare
|
usingtechnology
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the devcontainers we now have seven ports, but they are not labeled and it’s not obvious what they’re used for.
It would be better if we labeled these ports so that it was obvious what they were used for. It also appears that the 8081 port isn’t being used.
An example of these labels can be found in portsAttributes settings of this repo:
queue-management/.devcontainer/devcontainer.json at main · bcgov/queue-management
Acceptance Criteria
All of the ports have labels that make it obvious what they are used for.
Type of Change
fix (a bug fix)
Checklist